Narrow range in "replace" section of composer.json #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
approved these changes
Jun 19, 2020
|
IMO the replace needs to stay as it to make sure that if some of your lib requires ocramius/package-versions 1.2.* for example it can be overridden by requiring this fork. On the other hand, I guess releasing a new version with a narrower replace will allow composer to find either version 1.8.0 or 1.8.1 as a satisfactory solution, so it's probably fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "replace" range makes the package conflict with dependent that conflict with e.g.
"ocramius/package-versions": "<1.3"See getsentry/sentry-symfony#347 for a real-world application of this issue.
This could also be considered as a bug in Composer itself since the range has a non-empty intersection with the complement of the conflicting rule. But I don't know how difficult it would be to make Composer consider this refinement.