fix issue #122

composer-unused · Mar 8, 2024 · bd88aec · bd88aec
1 parent 460096c
commit bd88aec
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/Parser/PHP/DefinedSymbolCollector.php b/src/Parser/PHP/DefinedSymbolCollector.php
@@ -59,7 +59,11 @@ public function enterNode(Node $node)
             return NodeTraverser::DONT_TRAVERSE_CHILDREN;
         }
 
-        if ($node instanceof Node\Stmt\Expression && $node->expr instanceof Node\Expr\FuncCall) {
+        if (
+            $node instanceof Node\Stmt\Expression &&
+            $node->expr instanceof Node\Expr\FuncCall &&
+            $node->expr->name instanceof Node\Name
+        ) {
             /** @var Node\Name $expressionName */
             $expressionName = $node->expr->name;
             $functionName = $expressionName->getParts()[0] ?? null;

diff --git a/tests/Unit/Parser/PHP/SymbolNameParserTest.php b/tests/Unit/Parser/PHP/SymbolNameParserTest.php
@@ -81,4 +81,28 @@ class Foo extends MyClass implements NameSpace1\Bar, \Other\Namespace2\Baz {
         self::assertSame('My\NameSpace1\Bar', $symbols[2]);
         self::assertSame('Other\Namespace2\Baz', $symbols[3]);
     }
+
+    /**
+     * @test
+     * @link https://github.com/composer-unused/symbol-parser/issues/122
+     */
+    public function itShouldParseDefinedClosureDirectCalls(): void
+    {
+        $code = <<<'CODE'
+        <?php
+        $handlers = [
+            function () { echo "Hello Handler\n"; },
+        ];
+
+        foreach ($handlers as $handler) {
+            if (is_callable($handler)) {
+                $handler();
+            }
+        }
+        CODE;
+
+        $symbols = $this->parseDefinedSymbols($code);
+
+        self::assertCount(0, $symbols);
+    }
 }