This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
init command #279
Merged
init command #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 71.95% 72.19% +0.23%
==========================================
Files 33 33
Lines 2236 2273 +37
==========================================
+ Hits 1609 1641 +32
- Misses 486 487 +1
- Partials 141 145 +4
Continue to review full report at Codecov.
|
trinchan
reviewed
Feb 27, 2017
cmd/transporter/init.go
Outdated
| return err | ||
| } | ||
| defer appFileHandle.Close() | ||
| appFileHandle.WriteString("Source({name:\"source\", namespace:\"test./.*/\"}).save({name:\"sink\", namespace:\"test./.*/\"})\n") |
There was a problem hiding this comment.
Escaped quotes could be avoided using raw strings with backticks (`)
init [source] [sink] will create a stubbed out YAML and JS file with the defaults provided from calling SampleConfig of the adaptor fixes #254
jipperinbham
force-pushed
the
254-init-command
branch
from
a47bd1f to
66f785a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #254