Skip to content

Conversation

@glours
Copy link
Collaborator

@glours glours commented Sep 17, 2025

x-initialSync attribute was there for more than a year as an experimental feature to synchronize host content with services containers when sync+x triggers are setup, we think it could be now officially part of the specification

Compose Specification PR

See docker/docs#23345

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours requested a review from ndeloof as a code owner September 17, 2025 15:35
@glours glours self-assigned this Sep 17, 2025
@glours glours requested review from Copilot and ndeloof and removed request for ndeloof September 17, 2025 15:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR formalizes the experimental x-initialSync attribute by promoting it to an official initial_sync attribute in the Compose specification. This attribute ensures initial synchronization is performed before starting watch mode for sync+x triggers.

  • Adds initial_sync as a boolean field to the Trigger struct
  • Updates the JSON schema to include the new initial_sync property with proper documentation
  • Migrates existing test cases from the experimental x-initialSync to the new initial_sync attribute

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
types/develop.go Adds InitialSync boolean field to the Trigger struct with YAML/JSON tags
types/derived.gen.go Updates the generated deep copy function to include the new InitialSync field
schema/compose-spec.json Adds initial_sync boolean property to the JSON schema with description
loader/loader_test.go Updates test case to use the new initial_sync attribute instead of x-initialSync

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@glours glours requested review from aevesdocker and removed request for aevesdocker September 17, 2025 15:35
@ndeloof ndeloof merged commit 9a11fcb into compose-spec:main Sep 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants