Skip to content

Conversation

apollo13
Copy link
Contributor

@apollo13 apollo13 commented Apr 9, 2025

@ndeloof
Copy link
Collaborator

ndeloof commented Apr 9, 2025

for legal reasons, contributor's commit must be signed-off. Please amend and force-push your branch

By the way, what are you using x- extension fields for?

Fixes docker/compose#12724.

Signed-off-by: Florian Apolloner <florian@apolloner.eu>
@apollo13 apollo13 force-pushed the fb-merge-compose-extensions branch from 5cbbed9 to 0d4b187 Compare April 9, 2025 07:15
@apollo13
Copy link
Contributor Author

apollo13 commented Apr 9, 2025

for legal reasons, contributor's commit must be signed-off. Please amend and force-push your branch

Done, sorry.

By the way, what are you using x- extension fields for?

I am building my PaaS infrastructure for my homeservers & vms. Basically some ansible scripts that deploy compose units and I am using x- to embed metadata like backup information or credentials to create:

https://gitlab.com/rocketduck/paas/-/blob/ccd6e62e6f654f8140a1614934219c6163d1c95a/compose/paas-postgres/compose.yaml#L1-20

If this is something extensions are not supposed to be used for, please tell me and I will think of a different way. But currently this is shaping out really nicely.

@ndeloof ndeloof enabled auto-merge (rebase) April 9, 2025 07:31
@ndeloof ndeloof merged commit 583d2e1 into compose-spec:main Apr 9, 2025
8 checks passed
@apollo13 apollo13 deleted the fb-merge-compose-extensions branch April 9, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support merging of extensions ("x-something")
2 participants