Default to the processor's arch as host and target arch.#3
Merged
compnerd merged 14 commits intocompnerd:mainfrom Mar 8, 2025
Merged
Default to the processor's arch as host and target arch.#3compnerd merged 14 commits intocompnerd:mainfrom
compnerd merged 14 commits intocompnerd:mainfrom
Conversation
tristanlabelle
force-pushed
the
default-host-arch
branch
from
5606636 to
38fee07
Compare
compnerd
reviewed
Jan 15, 2025
|
@compnerd got time to look at this PR again? Looks pretty good. |
compnerd
reviewed
Feb 19, 2025
Owner
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Can you remove the pre-generation of the dist? That makes it confusing. We should just generate the dist in a post-push job I think.
Author
|
@compnerd PR comments addressed.
That would be nice to have but it's unrelated to this change. Previous changes similarly updated the dist. |
compnerd
approved these changes
Mar 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when running on an arm64 runner, the vsdevcmd would be configured to cross-build to amd64 by default. Better default to the host architecture, which itself defaults to the processor architecture.
Likewise,
componentswould default to looking for the x64 compiler, but we should rather look for the compiler based onarch.