Skip to content

Conversation

@carlos-adir
Copy link
Contributor

This PR removes the operators __float__ for the classes

  • JordanCurve: Use length property instead
  • SimpleShape: Use area property instead
  • ConnectedShape: Use area property instead
  • DisjoinShape: Use area property instead

Also removes __bool__ for SubSetR2.
Only EmptyShape and WholeShape contains this cast operation

@carlos-adir carlos-adir self-assigned this Aug 15, 2025
@carlos-adir carlos-adir added the refactor Tasks to improve readability / performance label Aug 15, 2025
@carlos-adir carlos-adir marked this pull request as ready for review August 15, 2025 08:32
@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.12%. Comparing base (6c8ea03) to head (5c88dda).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/shapepy/bool2d/shape.py 93.75% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   97.90%   98.12%   +0.22%     
==========================================
  Files          28       28              
  Lines        2432     2402      -30     
==========================================
- Hits         2381     2357      -24     
+ Misses         51       45       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlos-adir carlos-adir marked this pull request as draft August 15, 2025 08:39
@carlos-adir carlos-adir marked this pull request as ready for review August 15, 2025 08:39
@carlos-adir carlos-adir marked this pull request as draft August 15, 2025 08:43
@carlos-adir carlos-adir marked this pull request as ready for review August 15, 2025 08:46
@carlos-adir carlos-adir marked this pull request as draft August 15, 2025 09:03
@carlos-adir carlos-adir marked this pull request as ready for review August 15, 2025 09:03
@carlos-adir carlos-adir merged commit 30963dc into main Aug 15, 2025
9 of 10 checks passed
@carlos-adir carlos-adir deleted the dev/remove_float_cast branch August 15, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Tasks to improve readability / performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants