Skip to content

Fix: converting string into integers and rationals#6

Merged
carlos-adir merged 2 commits intomainfrom
dev/rational_from_str
Aug 4, 2025
Merged

Fix: converting string into integers and rationals#6
carlos-adir merged 2 commits intomainfrom
dev/rational_from_str

Conversation

@carlos-adir
Copy link
Contributor

As described by #5, the actual behaviour is:

>>> from rbool import *
>>> from_any("{-5, 3}")
{-5.0, 3.0}

This PR sets to:

>>> from_any("{-5, 3/7}")
{-5, 3/7}

The first one is transformed to integer, while the second is to fractions

@carlos-adir carlos-adir self-assigned this Aug 4, 2025
@carlos-adir carlos-adir added the bug Something isn't working label Aug 4, 2025
@carlos-adir carlos-adir linked an issue Aug 4, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.84%. Comparing base (820526e) to head (1d2da9e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files           9        9           
  Lines         650      660   +10     
=======================================
+ Hits          649      659   +10     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carlos-adir carlos-adir merged commit e09cd75 into main Aug 4, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect transformation of string to float

1 participant