fix(BCH-1112): dashboards are now showing only once #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where dashboard evidence entries with duplicate titles were showing multiple times in the dropdown selector. The fix introduces deduplication logic to show each unique title only once, while still allowing users to filter across all evidence entries with the same title using label conditions.
Changes:
- Added deduplication logic for evidence titles in the dropdown selector
- Refactored label filtering to work across all evidence entries sharing the selected title
- Improved type safety in TooltipIcon component by changing from
anytoComponent
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/views/control-implementations/partials/ControlStatementImplementation.vue | Implements deduplication of evidence titles in dropdown and updates label filtering logic to work with all entries sharing the selected title |
| src/components/TooltipIcon.vue | Improves type safety by replacing any type with Component type and removes unused props variable assignment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🧹 ESLint Report
✅ Linting completed automatically by CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.