-
Notifications
You must be signed in to change notification settings - Fork 1
feat: ui state cache #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ui state cache #152
Conversation
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces UI state caching improvements by making the control implementation workflow more resilient to undefined/null states and improving error handling.
Key changes:
- Enhanced prop reactivity with explicit watchers to handle implementation state changes
- Made statement prop optional to support loading and creation flows
- Improved error handling with try-catch blocks and better user feedback
- Converted Tailwind @apply directives to standard CSS for the hover state
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| IndexControlImplementation.vue | Added watch for implementation prop changes, improved error handling in onPartSelect function, updated conditional rendering in drawer to handle loading states, and converted CSS from @apply to standard media queries |
| ControlStatementImplementation.vue | Made statement prop optional and added defensive uuid checks in deleteByComponent, updateByComponent, and createByComponent functions to prevent runtime errors when statement is undefined |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/views/control-implementations/partials/IndexControlImplementation.vue
Outdated
Show resolved
Hide resolved
src/views/control-implementations/partials/ControlStatementImplementation.vue
Show resolved
Hide resolved
🧹 ESLint Report
✅ Linting completed automatically by CI. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.