-
Notifications
You must be signed in to change notification settings - Fork 1
feat: oidc #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: oidc #149
Conversation
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements SSO/OIDC authentication support and updates the user management API endpoints from /api/users to /api/admin/users. The changes include a new SSO callback flow, login UI updates with SSO provider buttons, enhanced user profile data display, and 403 permission error handling.
- Adds SSO/OIDC authentication with provider selection and callback handling
- Migrates user management endpoints to admin-scoped routes (
/api/admin/users) - Extends user model with authentication metadata fields (authMethod, authProvider, userAttributes)
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/users/UsersListView.vue | Updates API endpoint and adds 403 error handling with toast notification |
| src/views/users/UserView.vue | Updates API endpoints and displays new auth-related user fields |
| src/views/SSOCallbackView.vue | New view handling SSO callback with user fetching and redirect logic |
| src/views/LoginView.vue | Adds SSO provider UI with buttons, error notices, and provider loading |
| src/stores/types.ts | Extends CCFUser interface with optional auth fields |
| src/stores/auth.ts | Changes user type from local interface to CCFUser |
| src/router/index.ts | Adds SSO callback route and /login redirect to /auth/login |
| src/composables/useOIDC.ts | New composable for managing SSO providers and login initiation |
| src/components/users/UserEditForm.vue | Updates API endpoint to admin scope |
| src/components/users/UserCreateForm.vue | Updates API endpoint to admin scope |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🧹 ESLint Report
✅ Linting completed automatically by CI. |
feat: dark mode toggle button fix: dark mode color adjustments Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 13 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.