Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle varargs correctly in value_and_pullback!! and value_and_gradient!! #277

Merged
merged 3 commits into from
Sep 29, 2024

Conversation

willtebbutt
Copy link
Member

Addresses #273 .

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/interface.jl 91.66% <100.00%> (+0.23%) ⬆️

Copy link
Contributor

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬─────────┬─────────────┬─────────┐
│                      Label │ Mooncake │  Zygote │ ReverseDiff │  Enzyme │
│                     String │   String │  String │      String │  String │
├────────────────────────────┼──────────┼─────────┼─────────────┼─────────┤
│                   sum_1000 │    107.0 │     1.0 │        5.61 │     1.9 │
│                  _sum_1000 │     7.74 │  1330.0 │        34.3 │   0.106 │
│               sum_sin_1000 │      2.5 │    1.61 │        10.9 │    1.02 │
│              _sum_sin_1000 │     3.11 │   303.0 │        17.6 │    1.48 │
│                   kron_sum │     62.2 │    10.3 │       263.0 │    10.6 │
│              kron_view_sum │     28.4 │    3.86 │        88.0 │    4.75 │
│      naive_map_sin_cos_exp │     3.18 │ missing │        9.05 │    2.83 │
│            map_sin_cos_exp │     4.72 │    1.76 │         8.2 │    3.41 │
│      broadcast_sin_cos_exp │      4.3 │    3.62 │        1.68 │    2.83 │
│                 simple_mlp │     8.72 │    3.39 │        14.5 │    3.37 │
│                     gp_lml │     14.9 │    6.55 │     missing │ missing │
│ turing_broadcast_benchmark │     7.25 │ missing │        34.8 │ missing │
│         large_single_block │      3.9 │  4260.0 │        31.1 │    2.24 │
└────────────────────────────┴──────────┴─────────┴─────────────┴─────────┘

@willtebbutt willtebbutt merged commit 942eead into main Sep 29, 2024
17 checks passed
@willtebbutt willtebbutt deleted the wct/fix-vararg-value-pullback branch September 29, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant