[test additional commit] Adding OpenMP Kernels + explicitly load libomp.so by Vipul-Cariappa · Pull Request #432 · compiler-research/xeus-cpp

Vipul-Cariappa · 2026-01-13T12:46:27Z

No description provided.

codecov-commenter · 2026-01-13T12:52:13Z

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.94%. Comparing base (c357fd6) to head (42415e6).

Files with missing lines	Patch %	Lines
src/xinterpreter.cpp	83.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   81.94%   81.94%   -0.01%     
==========================================
  Files          21       21              
  Lines         853      864      +11     
  Branches       87       91       +4     
==========================================
+ Hits          699      708       +9     
- Misses        154      156       +2

Files with missing lines	Coverage Δ
src/xinterpreter.cpp	`90.00% <83.33%> (-0.57%)`	⬇️

Files with missing lines	Coverage Δ
src/xinterpreter.cpp	`90.00% <83.33%> (-0.57%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anutosh491 · 2026-01-13T13:01:53Z

Hey @Vipul-Cariappa , thanks a lot for this !

I'll take out some time soon to go through this.

Initial thoughts

I tried the wasm use case back in November or so. And though we can build libomp.so using emscripten, it's just how Jupyterlite and xeus is framed using pthreads this might not work. Pretty sure I wrote about my analysis in more detail on discord
Something which looks concerning & I personally feel should be handled better is the amount of kernels. We already have 6 native kernels (3 C, 3 C++) and 6 wasm kernels (3 C, 3 C++)

Now for any specific use case like this if we have 6 more kernels coming in, that would be an insane amount of kernels to maintain. We already expect cuda, out-of-process, debugger enabled kernels to land ... and any other python-interop, clad etc kernels in future.

I think for a specific functionality use case, we should just present our best kernel forward. One with the latest C++ version.

I'm guessing @JohanMabille & @SylvainCorlay would also agree to the same ?!

mcbarton · 2026-01-13T13:04:18Z

@anutosh491 This PR is not one that is supposed to be merged in. It is just to test an additional commit on top of my existing PR #389 which had been open for a while now.

Vipul-Cariappa · 2026-01-13T13:07:35Z

@mcbarton why are the OSX tests failing? Doesn't it pass on your local machine?

anutosh491 · 2026-01-13T13:07:41Z

those were just some thoughts ;)

mcbarton · 2026-01-13T13:15:05Z

@mcbarton why are the OSX tests failing? Doesn't it pass on your local machine?

No the test doesn't pass locally for me on osx.

github-actions

clang-tidy made some suggestions

github-actions · 2026-01-23T08:55:06Z

src/xinterpreter.cpp

  // FIXME: We should process the kernel input options and conditionally pass
  // the gpu args here.
-  return Cpp::CreateInterpreter(ClangArgs/*, {"-cuda"}*/);
+  Cpp::TInterp_t res = Cpp::CreateInterpreter(ClangArgs /*, {"-cuda"}*/);


warning: no header providing "Cpp::CreateInterpreter" is directly included [misc-include-cleaner]

Cpp::TInterp_t res = Cpp::CreateInterpreter(ClangArgs /*, {"-cuda"}*/); ^

github-actions · 2026-01-23T08:55:06Z

src/xinterpreter.cpp

  // FIXME: We should process the kernel input options and conditionally pass
  // the gpu args here.
-  return Cpp::CreateInterpreter(ClangArgs/*, {"-cuda"}*/);
+  Cpp::TInterp_t res = Cpp::CreateInterpreter(ClangArgs /*, {"-cuda"}*/);


warning: no header providing "Cpp::TInterp_t" is directly included [misc-include-cleaner]

Cpp::TInterp_t res = Cpp::CreateInterpreter(ClangArgs /*, {"-cuda"}*/); ^

github-actions · 2026-01-23T08:55:06Z

src/xinterpreter.cpp

+      )
+      != ClangArgs.end())
+  {
+      Cpp::LoadLibrary("libomp");


warning: no header providing "Cpp::LoadLibrary" is directly included [misc-include-cleaner]

Cpp::LoadLibrary("libomp"); ^

…p to native conda environment

Add export LD_LIBRARY_PATH="$CONDA_PREFIX/lib/:$LD_LIBRARY_PATH" to ci

…l spec

github-actions

clang-tidy made some suggestions

github-actions · 2026-01-29T15:34:04Z

src/xinterpreter.cpp

  // FIXME: We should process the kernel input options and conditionally pass
  // the gpu args here.
-  return Cpp::CreateInterpreter(ClangArgs/*, {"-cuda"}*/);
+  Cpp::TInterp_t res = Cpp::CreateInterpreter(ClangArgs /*, {"-cuda"}*/);


warning: no header providing "CppImpl::CreateInterpreter" is directly included [misc-include-cleaner]

Cpp::TInterp_t res = Cpp::CreateInterpreter(ClangArgs /*, {"-cuda"}*/); ^

github-actions · 2026-01-29T15:34:05Z

src/xinterpreter.cpp

  // FIXME: We should process the kernel input options and conditionally pass
  // the gpu args here.
-  return Cpp::CreateInterpreter(ClangArgs/*, {"-cuda"}*/);
+  Cpp::TInterp_t res = Cpp::CreateInterpreter(ClangArgs /*, {"-cuda"}*/);


warning: no header providing "CppImpl::TInterp_t" is directly included [misc-include-cleaner]

Cpp::TInterp_t res = Cpp::CreateInterpreter(ClangArgs /*, {"-cuda"}*/); ^

github-actions · 2026-01-29T15:34:05Z

src/xinterpreter.cpp

+      )
+      != ClangArgs.end())
+  {
+      Cpp::LoadLibrary("libomp");


warning: no header providing "CppImpl::LoadLibrary" is directly included [misc-include-cleaner]

Cpp::LoadLibrary("libomp"); ^

remove the need to set env var PATH & LD_LIBRARY_PATH for omp kernels

github-actions

clang-tidy made some suggestions

github-actions · 2026-01-30T09:09:14Z

src/xinterpreter.cpp

+      )
+      != ClangArgs.end())
+  {
+      if (!Cpp::LoadLibrary("libomp"))


warning: no header providing "CppImpl::LoadLibrary" is directly included [misc-include-cleaner]

if (!Cpp::LoadLibrary("libomp")) ^

github-actions · 2026-01-30T09:09:14Z

src/xinterpreter.cpp

+  {
+      if (!Cpp::LoadLibrary("libomp"))
+      {
+          std::cerr << "Failed to load libomp)" << std::endl;


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

std::cerr << "Failed to load libomp)" << std::endl;

std::cerr << "Failed to load libomp)" << '\n';

Vipul-Cariappa requested a review from mcbarton January 13, 2026 12:46

mcbarton changed the title ~~[WIP] Adding OpenMP Kernels~~ [test additional commit] Adding OpenMP Kernels + explicitly load libomp.so when required commit Jan 13, 2026

anutosh491 self-requested a review January 13, 2026 13:02

Vipul-Cariappa changed the title ~~[test additional commit] Adding OpenMP Kernels + explicitly load libomp.so when required commit~~ [test additional commit] Adding OpenMP Kernels + explicitly load libomp.so Jan 13, 2026

anutosh491 mentioned this pull request Jan 13, 2026

Add OpenMP kernels #389

Open

4 tasks

Vipul-Cariappa force-pushed the dev/mcbarton/Add-OpenMp-kernel branch from 3909d3a to 42415e6 Compare January 15, 2026 08:18

github-actions bot reviewed Jan 23, 2026

View reviewed changes

mcbarton and others added 9 commits January 29, 2026 14:47

Add c++17,c++20 and c++23 kernels all with openmp

f9ce177

Update cmake to configure added c++ + openmp kernels + add llvm-openm…

12f6fbd

…p to native conda environment

Add example notebooks for c++ + openmp kernels

78a0228

Add c + openmp kernels

1550c63

Configure c + openmp kernels cmake

0355fcc

Run existing tests for OpenMP kernels

50828c0

Add export LD_LIBRARY_PATH="$CONDA_PREFIX/lib/:$LD_LIBRARY_PATH" to ci

Add Simple OpenMP kernel test

558b597

Append :@XEUS_CPP_LD_LIBRARY_PATH@ to LD_LIBRARY_PATH in openmp kerne…

99c8b9a

…l spec

Apply suggestion now that CppInterOp v1.8.0 is out

c805b83

Vipul-Cariappa force-pushed the dev/mcbarton/Add-OpenMp-kernel branch from 48c7b41 to 5f77a23 Compare January 29, 2026 15:26

github-actions bot reviewed Jan 29, 2026

View reviewed changes

Try Vipul solution to failing bot

fcecfc1

Vipul-Cariappa force-pushed the dev/mcbarton/Add-OpenMp-kernel branch from 5f77a23 to a1c7a3a Compare January 30, 2026 08:56

explicitly load libomp.so when required

ebb4f8e

remove the need to set env var PATH & LD_LIBRARY_PATH for omp kernels

Vipul-Cariappa force-pushed the dev/mcbarton/Add-OpenMp-kernel branch from a1c7a3a to ebb4f8e Compare January 30, 2026 09:02

github-actions bot reviewed Jan 30, 2026

View reviewed changes

change compilers

93cf029

..

58740a7

	std::cerr << "Failed to load libomp)" << std::endl;
	std::cerr << "Failed to load libomp)" << '\n';

Conversation

Vipul-Cariappa commented Jan 13, 2026

Uh oh!

codecov-commenter commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

anutosh491 commented Jan 13, 2026

Uh oh!

mcbarton commented Jan 13, 2026

Uh oh!

Vipul-Cariappa commented Jan 13, 2026

Uh oh!

anutosh491 commented Jan 13, 2026

Uh oh!

mcbarton commented Jan 13, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Jan 13, 2026 •

edited

Loading