Skip to content

Conversation

mcbarton
Copy link
Collaborator

We current set the required version in cmake by a variable for other packages but not xeus-zmq. This PR fixes this, and updates the documentation to make clear 1.0.2 is needed as a minimum and not 1.0.0

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.08%. Comparing base (3ef699d) to head (1cf861a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   75.08%   75.08%           
=======================================
  Files          17       17           
  Lines         602      602           
  Branches       59       59           
=======================================
  Hits          452      452           
  Misses        150      150           

@anutosh491
Copy link
Collaborator

I have two things here

  1. Let's wait for the update to xeus 5 PR to go in (will do that by today) and then wait for this PR to build on top of that.
  2. Also we need to think if a minimum xeus_zmq version is even required. Cause if we're setting a minimum version for xeus .. that by itself might end up being sufficient. For eg xeus 5.0.0 is only comptabile with xeus-zmq 3.0.0 and xeus 4.0.0 (and above) is only comptabile with xeus-zmq 2.0.0 ... so technically ensuring a lower bound of xeus does ensure a lower bound on xeus-zmq

@mcbarton
Copy link
Collaborator Author

I have two things here

1. Let's wait for the update to xeus 5 PR to go in (will do that by today) and then wait for this PR to build on top of that.

2. Also we need to think if a minimum xeus_zmq version is even required. Cause if we're setting a minimum version for xeus .. that by itself might end up being sufficient. For eg xeus 5.0.0 is only comptabile with xeus-zmq 3.0.0 and xeus 4.0.0 (and above) is only comptabile with xeus-zmq 2.0.0 ... so technically ensuring a lower bound of xeus does ensure a lower bound on xeus-zmq

If xeus-zmq minimum version is not required i'll just drop the 1.0.2 from the cmake and remove the xeus-zmq in the readme.

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit 13e56df into compiler-research:main May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants