Fix bugs in documentation relating to environment variables #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
=======================================
Coverage 77.48% 77.48%
=======================================
Files 9 9
Lines 3713 3713
=======================================
Hits 2877 2877
Misses 836 836 🚀 New features to boost your workflow:
|
|
This PR is ready for review |
aaronj0
requested changes
May 29, 2025
| @@ -225,7 +225,7 @@ cd .\cling\ | |||
| git checkout tags/v1.0 | |||
| cd .. | |||
| git clone --depth=1 -b cling-llvm13 https://github.com/root-project/llvm-project.git | |||
There was a problem hiding this comment.
Suggested change
| git clone --depth=1 -b cling-llvm13 https://github.com/root-project/llvm-project.git | |
| git clone --depth=1 -b cling-llvm18 https://github.com/root-project/llvm-project.git |
There was a problem hiding this comment.
This PR was more about fixing the bugs in $env:ncpus on Windows, and the environment variables in general.
There was a problem hiding this comment.
I have updated the PR title and description to reflect this.
mcbarton
changed the title
mcbarton
force-pushed
the
Fix-bugs-in-documentation
branch
from
571f78d to
cf1b668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
This PR fixes some long standing bugs in documentation relating to environment variables.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist