Skip to content

[ci] Make Building and Testing cppyy in reusable action #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

This PR makes building and testing cppyy into a reusable action, reducing the repetition in the ci.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton force-pushed the Make-building-and-testing-cppyy-into-reusable-action branch 3 times, most recently from cac19fb to e474292 Compare May 28, 2025 08:57
@mcbarton mcbarton requested a review from vgvassilev May 28, 2025 09:41
Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm!

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.31%. Comparing base (de1e51b) to head (a1c2c43).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #602   +/-   ##
=======================================
  Coverage   77.31%   77.31%           
=======================================
  Files           9        9           
  Lines        3685     3685           
=======================================
  Hits         2849     2849           
  Misses        836      836           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton mcbarton force-pushed the Make-building-and-testing-cppyy-into-reusable-action branch 2 times, most recently from 8983f19 to 8390540 Compare May 28, 2025 10:39
@mcbarton mcbarton force-pushed the Make-building-and-testing-cppyy-into-reusable-action branch from 0442616 to a1c2c43 Compare May 28, 2025 12:28
Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcbarton
Copy link
Collaborator Author

LGTM!

I will merge once the ci passes. My first attempt took a little refinement, but is working now :)

@mcbarton mcbarton merged commit 83b0429 into compiler-research:main May 28, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants