Skip to content

Add smallpt example to deployment #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented May 27, 2025

Description

Please include a summary of changes, motivation and context for this PR.

Subject to compiler-research/xeus-cpp#316 in xeus-cpp going in, and found to be working, this PR adds the smallpt example to xeus-cpps deployment. I used this PR as an opportunity to add '--contents notebooks/images/marie.png --contents notebooks/audio/audio.wav' to the Emscripten build instructions too since they are missing.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton requested a review from anutosh491 May 27, 2025 12:05
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.43%. Comparing base (81cf53a) to head (581ed9f).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   76.43%   76.43%           
=======================================
  Files           9        9           
  Lines        3666     3666           
=======================================
  Hits         2802     2802           
  Misses        864      864           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton mcbarton marked this pull request as ready for review May 27, 2025 13:30
@mcbarton
Copy link
Collaborator Author

The smallpt example is now working in xeus-cpp (thanks for finding a fix), so this should be able to go in now @anutosh491

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vgvassilev vgvassilev merged commit d6471b9 into compiler-research:main May 27, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants