Add correct options to build xeus-cpp-lite deployment correctly #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
=======================================
Coverage 70.85% 70.85%
=======================================
Files 9 9
Lines 3538 3538
=======================================
Hits 2507 2507
Misses 1031 1031 |
anutosh491
reviewed
Jan 8, 2025
anutosh491
reviewed
Jan 9, 2025
anutosh491
reviewed
Jan 9, 2025
anutosh491
reviewed
Jan 9, 2025
mcbarton
force-pushed
the
fix-deployment-xeus-cpp
branch
from
9029534 to
ddaca90
Compare
anutosh491
approved these changes
Jan 10, 2025
Collaborator
anutosh491
left a comment
anutosh491
left a comment
There was a problem hiding this comment.
Looks good. Thanks !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
This PR should fix the emscripten build in the ci. The new llvm options may not be necessary. They are just used in emscripten-forge so I decided to add here for consistency. The LDFLAGS definitions are needed otherwise the CppInterOp shared library is not built correctly. I have cleared the cache of one build to check I have not broken the build there. Once it passes this PR should be ready for merging.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist