Update GetDatamembers and GetUnderlyingScope to work with UsingShadowDecl
#385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Vipul-Cariappa
force-pushed
the
dev/Protected-Using
branch
2 times, most recently
from
17e6475 to
9a4c472
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 70.56% 70.62% +0.06%
==========================================
Files 9 9
Lines 3496 3500 +4
==========================================
+ Hits 2467 2472 +5
+ Misses 1029 1028 -1
|
Collaborator
Author
|
Seg faults at cppyy without the patch for cppyy-backend. EDIT |
Vipul-Cariappa
added a commit
to Vipul-Cariappa/cppyy-backend-compiler-research
that referenced
this pull request
Dec 9, 2024
Since `Cpp::GetDatamembers` can potentially return `UsingShadowDecl` (compiler-research/CppInterOp#385), we will need to process datamembers through `GetUnderlyingScope`
Vipul-Cariappa
force-pushed
the
dev/Protected-Using
branch
from
9a4c472 to
5dfcd85
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
…hadowDecl` `GetDatamembers` now also returns `UsingShadowDecl` that point to `FieldDecl`. Update `GetUnderlyingScope` to return the target Decl of using statements. Simplified `CheckVariableAccess` logic.
Vipul-Cariappa
force-pushed
the
dev/Protected-Using
branch
from
5dfcd85 to
e943f38
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Vipul-Cariappa
added a commit
to Vipul-Cariappa/cppyy-compiler-research
that referenced
this pull request
Dec 11, 2024
Vipul-Cariappa
added a commit
to compiler-research/cppyy
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GetDatamembersnow also returnsUsingShadowDeclthat point toFieldDecl.Update
GetUnderlyingScopeto return the target Decl of using statements.Simplified
CheckVariableAccesslogic.Fixes
Towards fixing
test14_protected_accessin cppyy.