refactor Cpp::GetAllCppNames
#355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vipul-Cariappa
force-pushed
the
dev/GetAllCppNames
branch
from
8738a27 to
ed6fd23
Compare
vgvassilev
reviewed
Nov 28, 2024
| const std::vector<TemplateArgInfo>& arg_types); | ||
|
|
||
| CPPINTEROP_API std::vector<std::string> GetAllCppNames(TCppScope_t scope); | ||
| CPPINTEROP_API void GetAllCppNames(TCppScope_t scope, |
Contributor
There was a problem hiding this comment.
No, wait. I take that back.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| std::vector<std::string> GetAllCppNames(TCppScope_t scope) { | ||
| void GetAllCppNames(TCppScope_t scope, std::set<std::string>& names) { |
Contributor
There was a problem hiding this comment.
warning: no header providing "std::set" is directly included [misc-include-cleaner]
lib/Interpreter/CppInterOp.cpp:26:
- #if CLANG_VERSION_MAJOR >= 19
+ #include <set>
+ #if CLANG_VERSION_MAJOR >= 19
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 74.57% 74.55% -0.03%
==========================================
Files 8 8
Lines 3214 3211 -3
==========================================
- Hits 2397 2394 -3
Misses 817 817
|
Vipul-Cariappa
force-pushed
the
dev/GetAllCppNames
branch
from
f00daa4 to
80fecfa
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes in
std::set<std::string>&as an argument and populates it.