Remove unxip ci osx #348
Merged
Remove unxip ci osx #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
=======================================
Coverage 74.43% 74.43%
=======================================
Files 8 8
Lines 3204 3204
=======================================
Hits 2385 2385
Misses 819 819 |
Collaborator
|
@mcbarton @vgvassilev any idea why this fails on main with osx14 arm? |
Collaborator
Author
|
@aaronj0 The failures aren't do with this PR. It failed due to change which was made in cppyy-backend separately. This has now been fixed, so if you rerun the failing jobs they should pass now. |
Collaborator
|
Yep, just saw it thanks for letting me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the osx jobs in the ci are failing due to full Xcode requirement for unxip (see https://github.com/compiler-research/CppInterOp/actions/runs/11645652818/job/32429107514#step:12:175). This package description to me suggests this package is not needed https://formulae.brew.sh/formula/unxip . This PR remove unxip hopefully fixing the issue.