Skip to content

Conversation

@mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Oct 28, 2024

Coverage was set to try for all llvm cache builds. Didn't do anything to effect results but needs removing. Coverage was set to true for both llvm 18 and llvm 19 builds of CppInterOp. I've removed the true flag from the llvm 18 build so we have consistent coverage report results going forward.

@mcbarton mcbarton requested a review from vgvassilev October 28, 2024 20:14
@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.43%. Comparing base (9b5f4c5) to head (efbe39c).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   74.43%   74.43%           
=======================================
  Files           8        8           
  Lines        3204     3204           
=======================================
  Hits         2385     2385           
  Misses        819      819           

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcbarton mcbarton merged commit 444495e into compiler-research:main Oct 28, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants