Skip to content

Conversation

@vgvassilev
Copy link
Contributor

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@aaronj0
Copy link
Collaborator

aaronj0 commented Aug 29, 2024

rerunning jobs, since the first stage in the CI matrix did not run the InterOp build + unittests and a windows job was cancelled preventing the rest of the CI from running

@aaronj0 aaronj0 self-requested a review August 29, 2024 08:03
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.38%. Comparing base (af8e902) to head (ed84822).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   73.38%   73.38%           
=======================================
  Files           8        8           
  Lines        2979     2979           
=======================================
  Hits         2186     2186           
  Misses        793      793           
Files with missing lines Coverage Δ
lib/Interpreter/Compatibility.h 88.65% <100.00%> (ø)
Files with missing lines Coverage Δ
lib/Interpreter/Compatibility.h 88.65% <100.00%> (ø)

@aaronj0
Copy link
Collaborator

aaronj0 commented Aug 29, 2024

@vgvassilev looks like this is ready to be merged..

@aaronj0 aaronj0 force-pushed the support-recent-cling branch from 2580333 to ed84822 Compare August 29, 2024 12:37
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev vgvassilev merged commit 91e392d into compiler-research:main Aug 29, 2024
@vgvassilev vgvassilev deleted the support-recent-cling branch August 29, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants