Skip to content

Conversation

@mcbarton
Copy link
Collaborator

This PR will make CppInterOp compatible with llvm 19.

@codecov
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.54%. Comparing base (cff06c7) to head (93caa54).

Files Patch % Lines
lib/Interpreter/CppInterOp.cpp 61.53% 10 Missing ⚠️
lib/Interpreter/Paths.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   72.69%   72.54%   -0.16%     
==========================================
  Files           8        8              
  Lines        2963     2972       +9     
==========================================
+ Hits         2154     2156       +2     
- Misses        809      816       +7     
Files Coverage Δ
lib/Interpreter/Compatibility.h 88.65% <ø> (ø)
lib/Interpreter/CppInterOpInterpreter.h 75.94% <100.00%> (ø)
lib/Interpreter/DynamicLibraryManager.h 90.00% <100.00%> (ø)
lib/Interpreter/Paths.cpp 27.75% <0.00%> (ø)
lib/Interpreter/CppInterOp.cpp 79.06% <61.53%> (-0.31%) ⬇️
Files Coverage Δ
lib/Interpreter/Compatibility.h 88.65% <ø> (ø)
lib/Interpreter/CppInterOpInterpreter.h 75.94% <100.00%> (ø)
lib/Interpreter/DynamicLibraryManager.h 90.00% <100.00%> (ø)
lib/Interpreter/Paths.cpp 27.75% <0.00%> (ø)
lib/Interpreter/CppInterOp.cpp 79.06% <61.53%> (-0.31%) ⬇️

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton mcbarton marked this pull request as ready for review July 31, 2024 20:59
Co-Authored-By: Vassil Vassilev <v.g.vassilev@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @mcbarton!

@mcbarton mcbarton requested a review from vgvassilev August 1, 2024 09:08
@vgvassilev vgvassilev merged commit 34186d6 into compiler-research:main Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants