Update template function selection to use min required args #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
approved these changes
Jul 12, 2024
Contributor
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
LGTM, can you address clang-format?
aaronj0
force-pushed
the
stl-convertors-fix
branch
from
b47ea2d to
7387021
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 72.22% 72.69% +0.47%
==========================================
Files 8 8
Lines 2963 2963
==========================================
+ Hits 2140 2154 +14
+ Misses 823 809 -14
|
Contributor
|
@maximusron, can we add a test for this change? |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.