Remove unneeded installation of dependencies for Ubuntu wasm jobs #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The job failure is due to some issue with code coverage that keeps happening. @maximusron @vgvassilev can one of you merge this PR, and look at what is the issue with the code coverage job? |
Collaborator
|
@mcbarton looks like the token for codecov upload timed out on that job... the workflow is successful upon rerunning |
aaronj0
approved these changes
May 29, 2024
Collaborator
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of the ci seems unneeded. Its removal will speed up the wasm Ubuntu jobs.