[ci] Cppyy tests - fix pytest failing #233
Conversation
|
@maximusron The cppyy tests on osx arm still don't run after this change, but the osx x86 do (discluding the cling based one). It shouldn't be an issue, but can you turn off the parallel running of the tests for a run, so we can rule that out as an issue? |
aaronj0
changed the title
|
When a test crashes it crashes it cannot run the subsequent test cases. The pydist did that in a distributed way so that each test case gets run in isolation and if it crashes then we still get to see if others succeeded... |
|
@vgvassilev Maybe once the checks are done we can merge this so that we can see the test stats on main |
|
@maximusron can you rebase and fix the comment I made about apt not being present on osx in this PR #231? Without it the packges you added for tests on Ubuntu won't be present on osx |
| # We need PYTHONPATH later | ||
| echo "PYTHONPATH=$PYTHONPATH" >> $GITHUB_ENV | ||
| - name: Run the tests on Unix Systems | ||
| continue-on-error: true |
There was a problem hiding this comment.
@maximusron Maybe worth removing this line as part of this PR, so its clearer when this PR is a sucess without consulting the ci output.
There was a problem hiding this comment.
Yeah, that's probably a good idea.
There was a problem hiding this comment.
This will probably error out very fast, even if everything runs smoothly because the failing cppyy tests output stderr to the console.
There was a problem hiding this comment.
Ok, let's do that in a separate PR then..
|
I do not understand what’s the intent of removing pydist. The other changes seem fine. |
pydist is no longer being removed, that commit has been dropped |
3 participants
No description provided.