Remove redundant ci jobs #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
+ Coverage 78.53% 78.63% +0.09%
==========================================
Files 8 8
Lines 3056 3056
==========================================
+ Hits 2400 2403 +3
+ Misses 656 653 -3 |
Collaborator
Author
|
@alexander-penev can you review this PR for me? |
alexander-penev
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vgvassilev The non cppyy or xeus-clang-repl jobs for osx and Ubuntu are redundant. They don't do anything that the cppyy and xeus-clang-repl jobs don't (there was one small valgrind dependence for Ubuntu but this has been removed in this PR). I have removed them so that free Github runner minutes are not wasted, and so we can run through the osx jobs quicker (the maximum number of concurrent osx jobs allowed is 5, so we are currently have to wait longer than necessary for osx PR jobs to run).