Skip to content

Conversation

@SAtacker
Copy link
Contributor

It does not seem like this function is used.

Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>
Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM!

@codecov
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10097e0) 78.70% compared to head (f877fa6) 78.83%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   78.70%   78.83%   +0.12%     
==========================================
  Files           8        8              
  Lines        3053     3048       -5     
==========================================
  Hits         2403     2403              
+ Misses        650      645       -5     
Files Coverage Δ
lib/Interpreter/DynamicLibraryManagerSymbol.cpp 69.38% <ø> (+0.57%) ⬆️
Files Coverage Δ
lib/Interpreter/DynamicLibraryManagerSymbol.cpp 69.38% <ø> (+0.57%) ⬆️

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev
Copy link
Contributor

The failing windows platforms are expected to fail according to #191.

@vgvassilev vgvassilev merged commit e61e7ca into compiler-research:main Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants