Repository navigation
LAND-3b: train build tells the device run wrote lanes.json by its file time, not a content change - #92
Merged
Conversation
…ication time against the run's start, not by a content change: train 1's rebuilt position 1 merged #59's earlier position, whose lanes.json already held this tree's device run, so the new run wrote identical bytes and the build stopped with 'the device run did not rewrite'. deviceRunWrote is pinned in merge-train.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
LAND-3b: one fix to #76, found by the train 1 rebuild on 0d04dc0.
train buildchecked that the device run had rewrittenpackages/parity/out/lanes.jsonby asking git whether the file had changed. Position 1 of the rebuild merges #59's PR head (2d47e5d, the position from the earlier build). That head already holds this tree's device run, so the new run wrote byte-identical evidence (iOS 57 / Android 86, all other lanes passing). The build then stopped with "the device run did not rewrite packages/parity/out/lanes.json" although the run had completed. NowdeviceRunWrotecompares the file's modification time with the time the device step started (one second of slack for filesystem time resolution).What passed
pnpm typecheck: pass.deviceRunWrotetest does not compile against the previous scripts./tmp/heavy-lease.sh pnpm teston b209a8f: 3624 pass, 1 skipped (the DRAGON_REGEN_CHECK suite), 0 fail.Changed tests and checks
🤖 Generated with Claude Code