Repository navigation
land: report a parallel build's ejections as they happen (queue 58: #91 and #198 failed with no FAILED line) - #213
Merged
Merged
Conversation
…eyframes, and frame fixtures for the web easing, direction and fill gaps - css/aliases/animation.ts: the 14 Chrome 145 alias_for entries of transition and animation (none uses UseAliasParsing). - @-webkit-keyframes parses as @Keyframes (css_parser_impl.cc ConsumeKeyframesRule); a same-named unprefixed rule beats it in either order, as ScopedStyleResolver::AddKeyframeStyle decides; it keys its own at-rule:@-webkit-keyframes feature. - Frame fixtures (ltr and rtl): anim-easings (transition ease-in, ease-out, ease-in-out, step-start, step-end), anim-timing (every animation easing), anim-direction (alternate, reverse, fill backwards) and anim-webkit (every alias, alias and property in both orders, and the @-webkit-keyframes precedence).
…e, and list aliases.test.ts on the css_parser_impl.cc entry
… regen, fixed point after 4 passes; then pnpm notices:gen): the Chrome frame captures of anim-easings, anim-timing, anim-direction and anim-webkit (ltr and rtl), the web profile rows, the emitted CSS, NOTICES, the animator rt-vectors, the translate corpus and the host lanes record
… rt-vectors/animator/cases.json (ANIM-b2's frame fixtures bring it to 26), with a short-run check; it pinned 18
…(FAILED, label, comment), not only once the whole batch has built
Commands: pnpm regen; pnpm run parity:devices; pnpm regen
ANIM-b slice 2: -webkit- transition/animation aliases, @-webkit-keyframes, and web frame fixtures for easings, direction and fill backwards
Commands: pnpm regen
thejackshelton
added a commit
that referenced
this pull request
Oct 6, 2026
… into ovfl-a: no textual conflicts locally (GitHub's conflict was in files the dragon merge drivers resolve); fixtures.ts keeps master's groups and OVFL's overflow line
thejackshelton
added a commit
that referenced
this pull request
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (queue 58, /tmp/land.log 01:23 and 01:51): in a parallel build (#209), each PR's failure went into a slot.
prepareRoundreported the slots (FAILED line,landing-failedlabel, PR comment) only afterbuildAllreturned, which is after every position of the batch had built.land.statusshowed "0 of 4 handled".Fix:
buildAll(andbuildPositionsParallel) take afailed(index, error)callback, called the moment a position's PR is ejected: on assembly, a one-by-one fallback build, or after the speculation ended.prepareRoundreports through its normal path at that moment, so the driver's round logs FAILED, labels and comments then, exactly as the one-by-one build does. It then skips that slot when it maps the results, so each failure is reported once.What passed:
pnpm typecheckpassed.vitest run land-parallel land land-supervisor merge-trainpassed (148 tests).packages/parity/test/land-parallel.test.ts. Both fail without the fix (verified by stashing thescripts/change: 2 failed, 13 passed):prepareRoundslot test was changed to pass the new callback through (its signature changed).🤖 Generated with Claude Code