Skip to content

land: report a parallel build's ejections as they happen (queue 58: #91 and #198 failed with no FAILED line) - #213

Merged
thejackshelton merged 10 commits into
masterfrom
land-parallel-report
Oct 6, 2026
Merged

thejackshelton merged 10 commits into
masterfrom
land-parallel-report

Conversation

@thejackshelton

Copy link
Copy Markdown
Contributor

Bug (queue 58, /tmp/land.log 01:23 and 01:51): in a parallel build (#209), each PR's failure went into a slot. prepareRound reported the slots (FAILED line, landing-failed label, PR comment) only after buildAll returned, which is after every position of the batch had built.

Fix:

  • buildAll (and buildPositionsParallel) take a failed(index, error) callback, called the moment a position's PR is ejected: on assembly, a one-by-one fallback build, or after the speculation ended.
  • prepareRound reports through its normal path at that moment, so the driver's round logs FAILED, labels and comments then, exactly as the one-by-one build does. It then skips that slot when it maps the results, so each failure is reported once.
  • A builder's round collects the failures as before. A Fatal still stops the run.

What passed:

  • pnpm typecheck passed.
  • vitest run land-parallel land land-supervisor merge-train passed (148 tests).
  • 2 new tests in packages/parity/test/land-parallel.test.ts. Both fail without the fix (verified by stashing the scripts/ change: 2 failed, 13 passed):
    • queue 58's shape: a preparation that could not start, then a one-by-one failure, which is reported before the next position builds, and once;
    • an ejection while assembling, reported before the positions above are built.
  • The prepareRound slot test was changed to pass the new callback through (its signature changed).

🤖 Generated with Claude Code

thejackshelton and others added 10 commits October 5, 2026 19:48
…eyframes, and frame fixtures for the web easing, direction and fill gaps

- css/aliases/animation.ts: the 14 Chrome 145 alias_for entries of transition and animation (none uses UseAliasParsing).
- @-webkit-keyframes parses as @Keyframes (css_parser_impl.cc ConsumeKeyframesRule); a same-named unprefixed rule beats it
  in either order, as ScopedStyleResolver::AddKeyframeStyle decides; it keys its own at-rule:@-webkit-keyframes feature.
- Frame fixtures (ltr and rtl): anim-easings (transition ease-in, ease-out, ease-in-out, step-start, step-end), anim-timing
  (every animation easing), anim-direction (alternate, reverse, fill backwards) and anim-webkit (every alias, alias and
  property in both orders, and the @-webkit-keyframes precedence).
…e, and list aliases.test.ts on the css_parser_impl.cc entry
… regen, fixed point after 4 passes; then pnpm notices:gen): the Chrome frame captures of anim-easings, anim-timing, anim-direction and anim-webkit (ltr and rtl), the web profile rows, the emitted CSS, NOTICES, the animator rt-vectors, the translate corpus and the host lanes record
… rt-vectors/animator/cases.json (ANIM-b2's frame fixtures bring it to 26), with a short-run check; it pinned 18
…(FAILED, label, comment), not only once the whole batch has built
Commands: pnpm regen; pnpm run parity:devices; pnpm regen
ANIM-b slice 2: -webkit- transition/animation aliases, @-webkit-keyframes, and web frame fixtures for easings, direction and fill backwards
@thejackshelton
thejackshelton merged commit c9aeae0 into master Oct 6, 2026
5 checks passed
@thejackshelton
thejackshelton deleted the land-parallel-report branch October 6, 2026 08:43
thejackshelton added a commit that referenced this pull request Oct 6, 2026
… into ovfl-a: no textual conflicts locally (GitHub's conflict was in files the dragon merge drivers resolve); fixtures.ts keeps master's groups and OVFL's overflow line
thejackshelton added a commit that referenced this pull request Oct 6, 2026
…211 CTX-PROOF-3, #195 OVFL-na) into form-a-v2; no conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant