Repository navigation
full-test: the driver's proof skips the regen check its build already made; regen beside the shards; 4 Chrome shards - #204
Merged
Conversation
…ild already regenerated the tree); regen jobs beside the shards; 4 Chrome shards; durations from run 37399249352
…l), strict otherwise; a device failure is a judge-devices problem with a count per case and its first details, not a driver error (#91)
…s; MQ-PREF is MQ-R2 and waits for MQ-R1 runtime and PNT1
… Chrome-proven outline geometry; a1 web, a2 native, unstacked)
…grew 1 MiB: spawnSync git ENOBUFS failed the landing proof)
Commands: pnpm regen
Commands: pnpm regen
Commands: pnpm regen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed:
full-test.yml:regeninput (boolean, default true).regen-chromeandregen-hostrun only when it is true or the run is not a dispatch, so a manual dispatch and afulltestlabel run still check regen. The landing driver dispatches withregen=false(scripts/land-devices-ci.tsfullTestWorkflow).resolve, not the Chrome shards. With the 4 Chrome shards, one of the 6 macOS jobs then waits for the free plan's 5.scripts/test-durations.json: refreshed from runs 37399249352 and 37400820763 (231 files).Why skipping regen is safe for the driver:
buildPositionrunspnpm regenon every position it proves, andscripts/land.tsfails the build unless it exits 0. regen exits 0 only at a fixed point, a pass that changes nothing (MAX_PASSES 5, else "no fixed point"). The driver then runs the device lanes andpnpm regenagain, to its fixed point, and commits the outcome. The regen-only check then confirms that commit holds only regen outputs. So the tree it proves is a fixed point by construction. The workflow's splitregen --checkwould only re-prove that, with the same cache semantics and on the same toolchains.Measured wall time of a land-test proof (dispatch to run completed):
tailwind-sweep/sweep.test.tsalone, 300–414 s depending on what shares its runner. A shorter proof needs that file split (REGEN-SPEED/SLOW-SPLIT) or a fifth Chrome shard (the whole macOS cap).What passed:
pnpm typecheckpassed.vitest run land-devices-ci test-shards landpassed (112 tests).regen=false;resolveand run only when the input allows.🤖 Generated with Claude Code