Repository navigation
layout:vectors: 8 fixtures at once through chrome-pool (same vectors) - #168
Closed
thejackshelton wants to merge 2 commits into
Closed
thejackshelton wants to merge 2 commits into
thejackshelton wants to merge 2 commits into
Conversation
Contributor
Author
|
PM: closing. The review found that the pool keeps every fixture's full result in memory (vectors are 124 MB on disk), and the step showed no wall-time gain (76.6 s against a 68 s median), because it's compile-bound. The serial loop is kept. A follow-up could stream results inside the pool callback if this step ever becomes a bottleneck. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
packages/parity/src/cli/vectors.ts:runFixtureruns over the layout fixtures 8 at a time. The vectors and the 'skipped' lines are written in fixture order. Each fixture's own cases still run in sequence.This uses
inOrderandCHROME_PAGESfrompackages/parity/src/chrome-pool.ts(#162). That helper keeps results in item order. After a failure it starts nothing new, lets started items finish, and throws the first failure in item order. Each case already captures in its own browser context, so running cases side by side shares no state.What passed
pnpm typecheck: pass, before and after merging origin/master.pnpm regenon the branch (job regen-speed-pool-vectors): vectors ran. Fixed point after 1 pass, 0 files changed,git statusclean. The outputs are byte-identical. The proof ran before the merge with origin/master, which brought only Chrome captures: pixel, DPR and break captures take 8 cases at once (same bytes) #162's helper itself and other merged work, with no conflicts.chrome-pool.test.ts(Chrome captures: pixel, DPR and break captures take 8 cases at once (same bytes) #162).No tolerance, check, test or fixture changed.
🤖 Generated with Claude Code