Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ss/add server.js #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ss/add server.js #2

wants to merge 2 commits into from

Conversation

samrshi
Copy link

@samrshi samrshi commented Jan 20, 2022

Issue #1 mentions that server.js was not present. I copied the started code from the assignment write-up into a file named server.js

@samrshi samrshi changed the title Ss/add server.js ss/add server.js Jan 20, 2022
@samrshi samrshi requested a review from jdmar3 January 20, 2022 20:47
@camsimba
Copy link

@samrshi Hey Sam, I think the intended file is 'server.js.example' and is included in the original repository. I think this is a good change, as the discrepancy between the write-up and repository could be confusing for students!

@samrshi
Copy link
Author

samrshi commented Jan 21, 2022

@samrshi Hey Sam, I think the intended file is 'server.js.example' and is included in the original repository. I think this is a good change, as the discrepancy between the write-up and repository could be confusing for students!

Looking at the commit times, it seems like server.js.example was added a little bit after I created my PR. I also think it might be good to call the file server.js since they'll be setting server.js as main in their package.json. I can envision a class of errors where npm start doesn't run if they do work in server.js.example and don't change its name.

@jdmar3 jdmar3 added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 27, 2022
@jdmar3
Copy link
Contributor

jdmar3 commented Jan 27, 2022

This is a good point, RE the class of errors related to not changing the name of server.js, but I also kind of want that to happen. I did updated the instructions to include references to server.js.example and an explicit instruction about copying or moving that file to the right name. So, if they don't do that and get an error, that will be a good opportunity to learn to run down an error message. We're going to talk about errors and testing and the autograders in class today (2022-01-27) and I will use this as an example.

@jdmar3 jdmar3 self-assigned this Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants