Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Script: calibre-server #960

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Conversation

ThisIsJeron
Copy link
Contributor

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.


✍️ Description

Create a new script that adds calibre-server as an LXC


🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Dec 21, 2024
install/calibre-server-install.sh Outdated Show resolved Hide resolved
install/calibre-server-install.sh Outdated Show resolved Hide resolved
# Potentially re-run the official calibre script to ensure most recent version
# to keep logic consistent with how other scripts handle updates.
msg_info "Updating Calibre (latest)"
wget -nv -O- https://download.calibre-ebook.com/linux-installer.sh | sh /dev/stdin &>/dev/null

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible check if there is a newer version wich needs to be installed. Have a look at the snipeit.sh file for reference.

json/calibre-server.json Show resolved Hide resolved
json/calibre-server.json Outdated Show resolved Hide resolved
install/calibre-server-install.sh Outdated Show resolved Hide resolved
install/calibre-server-install.sh Outdated Show resolved Hide resolved
install/calibre-server-install.sh Outdated Show resolved Hide resolved
@ThisIsJeron
Copy link
Contributor Author

hey @michelroegl-brunner , thank you for taking a look through my PR. I had actually set this up as a draft and wasn't expecting anyone to review. I will update with your recommended changes when I get the chance!

@michelroegl-brunner
Copy link
Member

@ThisIsJeron Any progress on this so far?

@MickLesk MickLesk dismissed michelroegl-brunner’s stale review January 9, 2025 15:21

without check because latest

@MickLesk MickLesk marked this pull request as ready for review January 9, 2025 15:21
@MickLesk MickLesk requested a review from a team as a code owner January 9, 2025 15:21
@MickLesk MickLesk merged commit eb8ebfe into community-scripts:main Jan 9, 2025
4 of 5 checks passed
@MickLesk MickLesk added invalid This doesn't seem right wontdo This will not be worked on ✅ Completed and removed website A change to the website new script A change that adds a new script invalid This doesn't seem right ✅ Completed labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontdo This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants