Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove PHP Key generation in Bookstack Update #948

Merged

Conversation

michelroegl-brunner
Copy link
Member

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.


✍️ Description

Removes the Keygeneration in the Update Function. It was in there forever, but is accorfing to the Documentation not necessery: Bookstack Update Doc



🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner December 20, 2024 18:09
@github-actions github-actions bot added the update script A change that updates a script label Dec 20, 2024
@MickLesk MickLesk merged commit d74ad31 into community-scripts:main Dec 20, 2024
1 check passed
dsiebel pushed a commit to dsiebel/ProxmoxVE that referenced this pull request Dec 27, 2024
@michelroegl-brunner michelroegl-brunner deleted the bookstack_hotfix branch December 29, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants