Skip to content

openhab. correct some typos - #4448

Merged
michelroegl-brunner merged 2 commits into
community-scripts:mainfrom
moodyblue:main
May 13, 2025
Merged

michelroegl-brunner merged 2 commits into
community-scripts:mainfrom
moodyblue:main

Conversation

@moodyblue

@moodyblue moodyblue commented May 13, 2025 •

Copy link
Copy Markdown
Contributor

Add sudo in lines 24 and 25

✍️ Description

Missing sudo in some commands

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Add sudo in lines 24 and 25
@moodyblue
moodyblue requested a review from a team as a code owner May 13, 2025 16:01
@github-actions github-actions Bot added bugfix update script A change that updates a script labels May 13, 2025
@tremor021

Copy link
Copy Markdown
Member

Why sudo when script is executed as root?

@moodyblue

Copy link
Copy Markdown
Contributor Author

The fact is that it fails without sudo and runs ok with sudo

@tremor021

tremor021 commented May 13, 2025 •

Copy link
Copy Markdown
Member

image
image

no it doesn't, works fine

@tremor021

Copy link
Copy Markdown
Member

I fixed it for you

@moodyblue

Copy link
Copy Markdown
Contributor Author

A million thanks

@michelroegl-brunner
michelroegl-brunner merged commit db81851 into community-scripts:main May 13, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

refactor update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants