Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify changes before commit in changelog-pr.yml #310

Merged

Conversation

havardthom
Copy link
Contributor

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Fixes failing workflow when there are no changes

image

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

@havardthom havardthom requested a review from a team as a code owner November 17, 2024 16:42
@github-actions github-actions bot added the maintenance Code maintenance or general upkeep of the project label Nov 17, 2024
@MickLesk
Copy link
Member

Add a check that the changelog.md does not need 2 reviewers. Either one or the github-bot should just do it directly.

@havardthom
Copy link
Contributor Author

Add a check that the changelog.md does not need 2 reviewers. Either one or the github-bot should just do it directly.

Yes we can probably fix that in the ruleset. Should have one pair of eyes on it before merge, incase something is wrong / unlabelled then it can be fixed before merging

@MickLesk
Copy link
Member

Then 1 Reviewer is perfect :-) 👍

@newzealandpaul newzealandpaul merged commit b9e8454 into community-scripts:main Nov 18, 2024
1 check passed
@havardthom havardthom deleted the fix-changelog-workflow branch November 24, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code maintenance or general upkeep of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants