Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wavelog Script #259

Merged
merged 6 commits into from
Nov 16, 2024
Merged

Conversation

DonLocke
Copy link
Contributor

Description

Added a new script to deploy Wavelog, a web-based amateur radio logbook, in a LXC.

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Related Pull Requests / Discussions

@DonLocke DonLocke requested a review from a team as a code owner November 15, 2024 02:51
@github-actions github-actions bot added new script A change that adds a new script documentation A change to documentation labels Nov 15, 2024
@newzealandpaul
Copy link
Contributor

Good work @DonLocke . I recomend this script be added, but I am not approving as I am unable to test it right now.

Copy link
Member

@MickLesk MickLesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a few comments. Otherwise the script seems to work.

Unfortunately I can't test it completely because I have absolutely no idea about the stuff and what I should enter for some things :-D

image

ct/wavelog.sh Outdated Show resolved Hide resolved
install/wavelog-install.sh Show resolved Hide resolved
install/wavelog-install.sh Show resolved Hide resolved
install/wavelog-install.sh Outdated Show resolved Hide resolved
@DonLocke
Copy link
Contributor Author

I have added a few comments. Otherwise the script seems to work.

Unfortunately I can't test it completely because I have absolutely no idea about the stuff and what I should enter for some things :-D

image

For the purposes of testing, you can use the "default" values, 4W7EST and HA44AA.

MickLesk
MickLesk previously approved these changes Nov 15, 2024
havardthom
havardthom previously approved these changes Nov 15, 2024
ct/wavelog.sh Outdated Show resolved Hide resolved
install/wavelog-install.sh Show resolved Hide resolved
json/wavelog.json Outdated Show resolved Hide resolved
Co-authored-by: Håvard Gjøby Thom <34199185+havardthom@users.noreply.github.com>
@MickLesk MickLesk dismissed stale reviews from havardthom and themself via 9fbbd9c November 15, 2024 22:02
Copy link
Contributor

@havardthom havardthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution

@MickLesk MickLesk merged commit bae7914 into community-scripts:main Nov 16, 2024
1 check passed
@DonLocke DonLocke deleted the add-wavelog-script branch November 16, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation A change to documentation new script A change that adds a new script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants