Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] cleanup (remove base_settings & unneeded comments) #2351

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

MickLesk
Copy link
Member

✍️ Description

  • remove base_settings (already declared in build.func)
  • remove unneeded comments
  • remove unneeded empty lines

🔗 Related PR / Discussion / Issue

  • generel cleanup

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

  • Self-review performed – Code follows established patterns and conventions.
  • Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

  • New feature – Adds new, non-breaking functionality.

@MickLesk MickLesk requested a review from a team as a code owner February 13, 2025 13:17
@github-actions github-actions bot added update script A change that updates a script maintenance Code maintenance or general upkeep of the project labels Feb 13, 2025
Copy link
Contributor

⚠️ The script ct/2fauth.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/actualbudget.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/adguard.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/adventurelog.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/agentdvr.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/alpine-docker.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/alpine-grafana.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/alpine-it-tools.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/alpine-nextcloud.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/alpine-vaultwarden.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/alpine-zigbee2mqtt.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/alpine.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/apache-cassandra.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/apache-couchdb.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/apache-guacamole.sh failed with the following message:

TERM environment variable not set.
TERM environment variable needs set.
TERM environment variable not set.
/dev/fd/63: line 73: SPINNER_PID: unbound variable

Copy link
Contributor

⚠️ The script ct/apache-tika.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/apt-cacher-ng.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/archivebox.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/aria2.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/audiobookshelf.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/authentik.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/autobrr.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/baikal.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/barcode-buddy.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/bazarr.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/beszel.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/umami.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/umbrel.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/unbound.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/unifi.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/unmanic.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/uptimekuma.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/urbackupserver.sh failed with the following message:

TERM environment variable not set.
TERM environment variable needs set.
TERM environment variable not set.
/dev/fd/63: line 73: SPINNER_PID: unbound variable

Copy link
Contributor

⚠️ The script ct/vaultwarden.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/vikunja.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/wallos.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/wastebin.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/watchyourlan.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/wavelog.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/whisparr.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/whoogle.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/wikijs.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/wireguard.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/wordpress.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/yunohost.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/zabbix.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/zammad.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/zerotier-one.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/zigbee2mqtt.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/zipline.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/zitadel.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/zoraxy.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

Copy link
Contributor

⚠️ The script ct/zwave-js-ui.sh failed with the following message:

.github/workflows/scripts/app-test/pr-build.func: line 140: CT_TYPE: unbound variable

@michelroegl-brunner michelroegl-brunner merged commit 6f13193 into main Feb 13, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code maintenance or general upkeep of the project update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants