Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actual update - missing hidden files, downloaded release cleanup #2027

Merged

Conversation

maciejmatczak
Copy link
Contributor

✍️ Description

Fixes #1707.

Update script had different logic around folder and file movement when compared to install script, I followed install script logic.

Update script did not move the hidden files (dotfiles) from newly downloaded release of Actual Budget due to bash, by default, not matching dot files (mv *ctual-server-*/* behavior depends on bash's dotglob option).

The bottom rm -rf of .tar.gz seemed not effective - I updated it to follow install script logic.



✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • [] New feature (non-breaking change that adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • [] New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

@maciejmatczak maciejmatczak requested a review from a team as a code owner February 4, 2025 16:58
@github-actions github-actions bot added the update script A change that updates a script label Feb 4, 2025
Copy link
Member

@MickLesk MickLesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@michelroegl-brunner michelroegl-brunner merged commit e753120 into community-scripts:main Feb 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actual Budget Update Failing
3 participants