Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cifs support in ubuntu2404-vm.sh #1461

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

plonxyz
Copy link

@plonxyz plonxyz commented Jan 13, 2025

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.


✍️ Description

Provide a summary of the changes made and/or reference the issue being addressed.

added cifs to
case $STORAGE_TYPE in
nfs | dir | cifs)

So VMs can be deployed on cifs shares


Please remove unneeded lines!


🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

added cifs to 
case $STORAGE_TYPE in
nfs | dir | cifs)

So VMs can be deployed on cifs shares
@plonxyz plonxyz requested a review from a team as a code owner January 13, 2025 21:47
@github-actions github-actions bot added the update script A change that updates a script label Jan 13, 2025
@MickLesk
Copy link
Member

why only for ubuntu24.04? Whats with the other vms like 22.04, debian 11, 12?

@plonxyz
Copy link
Author

plonxyz commented Jan 14, 2025

sure I can do it on all , but I needed a 24.04 and therefore just pushed a fix there

@MickLesk
Copy link
Member

will you do it for all and i push, or single prs?

@michelroegl-brunner
Copy link
Member

I would suggest do it in one pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants