Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeDetection Update: Update also Browsers #1027

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

Niklas04
Copy link
Contributor

@Niklas04 Niklas04 commented Dec 26, 2024

✍️ Description

In ChangeDetection-Script (ct/changedetection.sh):

  • Update also browsers in function update_script
  • Adding more messages in function update_script
  • Make function update_script more readable by adding line breaks


🛠️ Type of Change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Fix an issue (#1026) that Browserless-service is not starting up after an update of Broswerless and/or Playwright, because now chromium_headless is needed and/or the installed version of the browsers are not compatible anymore.

This fix was verified by me by upgrading from a working backup. Also could reproduce the issue when updating from the working backup beforehand.

@Niklas04 Niklas04 requested a review from a team as a code owner December 26, 2024 18:43
@github-actions github-actions bot added the update script A change that updates a script label Dec 26, 2024
@MickLesk MickLesk merged commit e253fe6 into community-scripts:main Dec 26, 2024
2 checks passed
dsiebel pushed a commit to dsiebel/ProxmoxVE that referenced this pull request Dec 27, 2024
* Changedetection: Update also browsers

* Changedetection: Adding more msg for updating, Make code more readable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants