Skip to content
  • Rate limit · GitHub

    Access has been restricted

    You have triggered a rate limit.

    Please wait a few minutes before you try again;
    in some cases this may take up to an hour.

  • Notifications You must be signed in to change notification settings
  • Fork 956
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Proxmox DataCenter: incorrect build.func url #1013

Rate limit · GitHub

Access has been restricted

You have triggered a rate limit.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

Conversation

rbradley0
Copy link
Contributor

@rbradley0 rbradley0 commented Dec 26, 2024

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.


✍️ Description

Provide a summary of the changes made and/or reference the issue being addressed.

When originally committed, the Proxmox Datacenter Manager script uses the incorrect URL path for sourcing the build.func script from this repo in turn causing the script to fail when trying to use it.


Please remove unneeded lines!


🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

Rate limit · GitHub

Access has been restricted

You have triggered a rate limit.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

@rbradley0 rbradley0 requested a review from a team as a code owner December 26, 2024 03:41
@github-actions github-actions bot added the update script A change that updates a script label Dec 26, 2024
@rbradley0 rbradley0 changed the title Fix Script: Fix broken build.func url Fix Script: Update incorrect build.func url Dec 26, 2024
@MickLesk MickLesk changed the title Fix Script: Update incorrect build.func url Fix Proxmox DataCenter: incorrect build.func url Dec 26, 2024
@MickLesk MickLesk merged commit 7aca36a into community-scripts:main Dec 26, 2024
4 checks passed
dsiebel pushed a commit to dsiebel/ProxmoxVE that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate limit · GitHub

Access has been restricted

You have triggered a rate limit.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

2 participants