Version lable displayed in the Game Profile card is not updated correctly

[R3voA3]

Notice the patch version:

Notice what version the card shows:

[coderabbitai]

Coding Plan

Summary

• Extend the existing UpdateProfileRequest → UpdateProfileAsync flow to support GameClient.Version updates, maintaining architectural consistency
• Modify ProfileContentService.AddContentToProfileAsync to detect game client (patch) content and propagate its version
• Update GameProfileItemViewModel to prioritize the updated GameClient.Version when publisher content is present
• No schema changes required; leverages existing observable properties that already trigger UI updates via PropertyChanged

Design Choices

Design Choice 1: How should patch version be propagated when content is added to a profile?

Options Considered:

1. Store version in GameClient.Version when patch content is added, extend UpdateProfileRequest to support version updates
2. Have ViewModel look up manifest repository during construction to get patch version
3. Add a separate DisplayVersion field to GameProfile model

Chosen Option: 1

Rationale: Extend the existing update flow to include version updates. This aligns with current architecture patterns and avoids adding service dependencies to the ViewModel or changing the data model schema.

💡 User Tips

Regenerate the plan with different choices with @coderabbitai <feedback>.

Implementation Steps

Phase 1: Enable Version Updates in Profile Service Layer

Enable the profile update mechanism to accept and persist version changes, allowing downstream services to update GameClient.Version when patch content is added.

Task 1: Extend UpdateProfileRequest with Version Field

Add a version field to the request DTO so callers can specify a version update alongside other profile changes.

• Add nullable GameClientVersion property to GenHub/GenHub.Core/Models/GameProfile/UpdateProfileRequest.cs
• Document the property's purpose: updating the displayed version when patch content is applied

Task 2: Update GameProfileManager to Handle Version Updates

Modify the update method to apply version changes from the request.

• In GenHub/GenHub/Features/GameProfiles/Services/GameProfileManager.cs, update UpdateProfileAsync method
• After loading the profile, check if request.GameClientVersion has a value
• If present and non-empty, update profile.GameClient.Version with the new value
• Ensure this update persists when the profile is saved

🤖 Prompt for AI agents

This phase extends the profile service layer to support version updates. The
goal is to allow callers to pass a new `GameClient.Version` value through the
existing update flow and have it persisted.

**Task 1: Extend `UpdateProfileRequest`**
- File: `GenHub/GenHub.Core/Models/GameProfile/UpdateProfileRequest.cs`
- Add a new nullable `GameClientVersion` property
- Add documentation indicating its purpose: updating the displayed version when
patch content is applied

**Task 2: Update `GameProfileManager.UpdateProfileAsync`**
- File: `GenHub/GenHub/Features/GameProfiles/Services/GameProfileManager.cs`
- In the `UpdateProfileAsync` method, after loading the profile, add a check for
`request.GameClientVersion`
- If the value is present and non-empty, assign it to
`profile.GameClient.Version`
- Confirm the profile is saved after this update so the change is persisted

Phase 2: Set Patch Version When Adding Content

Update the content addition flow to detect when game client (patch) content is being added and propagate the patch version to the profile.

Task 1: Identify Game Client Content When Adding

Determine if added content represents a patch that should update the profile's displayed version.

• In GenHub/GenHub/Features/GameProfiles/Services/ProfileContentService.cs, within AddContentToProfileAsync
• After resolving the content manifest, check if the manifest represents a game client content type
• Game client manifests have ContentType.GameClient or can be identified by manifest ID pattern

Task 2: Extract and Set Patch Version

When game client content is detected, extract its version and include it in the profile update.

• Get the Version field from the resolved manifest (contains the display version like "v2024.11.18")
• Modify the UpdateProfileRequest construction to include GameClientVersion = manifest.Version
• This propagates the patch version through the existing update flow to persist in GameClient.Version

🤖 Prompt for AI agents

This phase updates the content addition flow to detect patch content and
propagate its version to the profile. The goal is to ensure that when a game
client (patch) is added, its version is stored in `GameClient.Version`.

**File:
`GenHub/GenHub/Features/GameProfiles/Services/ProfileContentService.cs`**
- Locate the `AddContentToProfileAsync` method
- After resolving the content manifest, add a check to determine if the manifest
is a game client content type
  - Identify by `ContentType.GameClient` or manifest ID pattern
- If game client content is detected:
  - Read the `Version` field from the resolved manifest (e.g., "v2024.11.18")
- When constructing `UpdateProfileRequest`, include `GameClientVersion =
manifest.Version`
- This causes the existing update flow (updated in Phase 1) to persist the patch
version into `GameClient.Version`

Phase 3: Fix ViewModel Version Display Priority

Update the ViewModel to correctly prioritize the patch version when publisher content is present in the profile.

Task 1: Detect Publisher Content in EnabledContentIds

Identify when a profile has patch content applied by checking the enabled content IDs.

• In GenHub/GenHub/Features/GameProfiles/ViewModels/GameProfileItemViewModel.cs, in the constructor after the installation manifest extraction
• Check if EnabledContentIds contains manifest IDs that are publisher game clients (not base installation)
• Publisher manifests can be identified by segment pattern: IDs without -installation suffix that have a publisher segment indicating community content (thesuperhackers, generalsonline, etc.)

Task 2: Prioritize GameClient.Version for Patched Profiles

When publisher content is detected, use the now-correctly-updated GameClient.Version instead of the parsed installation manifest version.

• If publisher game client content is detected in EnabledContentIds
• Override _gameVersion with GameClient.Version (which now contains the patch version from Phase 2)
• Apply the existing sentinel string checks (filter out "Unknown", "Auto-Updated", "Automatically added")
• This ensures patched profiles display the patch version while unpatched profiles continue showing base game version

🤖 Prompt for AI agents

This phase updates the ViewModel to correctly display the patch version when
publisher content is present. The goal is to prioritize `GameClient.Version`
(which now contains the patch version after Phase 2) over the parsed
installation manifest version.

**File:
`GenHub/GenHub/Features/GameProfiles/ViewModels/GameProfileItemViewModel.cs`**
- In the constructor, after the existing installation manifest extraction logic:
  - Inspect `EnabledContentIds` to check for publisher game client manifest IDs
- Publisher manifests are identified by: no `-installation` suffix, and a
publisher segment indicating community content (e.g., thesuperhackers,
generalsonline, etc.)
- If such publisher content is detected:
  - Override `_gameVersion` with the value from `GameClient.Version`
- Apply the existing sentinel string checks — filter out values like "Unknown",
"Auto-Updated", "Automatically added"
- If no publisher content is detected, retain the existing behavior (base game
version from manifest ID parsing)
- This ensures patched profiles show the patch version while unpatched profiles
continue displaying the base game version

Research

GenHub is an Avalonia-based desktop application for managing game profiles. The project follows MVVM architecture with:

• GenHub.Core: Domain models (GameProfile, GameClient), service interfaces, constants
• GenHub: UI layer with ViewModels, Views (AXAML), and feature services

Key components for this fix:

• GameProfileItemViewModel: Displays profile cards; derives GameVersion from manifest ID parsing with fallback to GameClient.Version
• GameProfileManager: Manages profile CRUD via UpdateProfileAsync
• ProfileContentService: Handles adding content to profiles via AddContentToProfileAsync
• UpdateProfileRequest: DTO for profile update operations (currently lacks version support)

The root cause: When patch content is added to an existing profile, only EnabledContentIds is updated. GameClient.Version remains unchanged from profile creation, and the ViewModel prioritizes parsing the installation manifest ID, showing the base game version.

---

🚀 Next Steps

🤖 All AI agent prompts combined

Task: 1

This phase extends the profile service layer to support version updates. The
goal is to allow callers to pass a new `GameClient.Version` value through the
existing update flow and have it persisted.

**Task 1: Extend `UpdateProfileRequest`**
- File: `GenHub/GenHub.Core/Models/GameProfile/UpdateProfileRequest.cs`
- Add a new nullable `GameClientVersion` property
- Add documentation indicating its purpose: updating the displayed version when
patch content is applied

**Task 2: Update `GameProfileManager.UpdateProfileAsync`**
- File: `GenHub/GenHub/Features/GameProfiles/Services/GameProfileManager.cs`
- In the `UpdateProfileAsync` method, after loading the profile, add a check for
`request.GameClientVersion`
- If the value is present and non-empty, assign it to
`profile.GameClient.Version`
- Confirm the profile is saved after this update so the change is persisted
===============================================================================

Task: 2

This phase updates the content addition flow to detect patch content and
propagate its version to the profile. The goal is to ensure that when a game
client (patch) is added, its version is stored in `GameClient.Version`.

**File:
`GenHub/GenHub/Features/GameProfiles/Services/ProfileContentService.cs`**
- Locate the `AddContentToProfileAsync` method
- After resolving the content manifest, add a check to determine if the manifest
is a game client content type
  - Identify by `ContentType.GameClient` or manifest ID pattern
- If game client content is detected:
  - Read the `Version` field from the resolved manifest (e.g., "v2024.11.18")
- When constructing `UpdateProfileRequest`, include `GameClientVersion =
manifest.Version`
- This causes the existing update flow (updated in Phase 1) to persist the patch
version into `GameClient.Version`
===============================================================================

Task: 3

This phase updates the ViewModel to correctly display the patch version when
publisher content is present. The goal is to prioritize `GameClient.Version`
(which now contains the patch version after Phase 2) over the parsed
installation manifest version.

**File:
`GenHub/GenHub/Features/GameProfiles/ViewModels/GameProfileItemViewModel.cs`**
- In the constructor, after the existing installation manifest extraction logic:
  - Inspect `EnabledContentIds` to check for publisher game client manifest IDs
- Publisher manifests are identified by: no `-installation` suffix, and a
publisher segment indicating community content (e.g., thesuperhackers,
generalsonline, etc.)
- If such publisher content is detected:
  - Override `_gameVersion` with the value from `GameClient.Version`
- Apply the existing sentinel string checks — filter out values like "Unknown",
"Auto-Updated", "Automatically added"
- If no publisher content is detected, retain the existing behavior (base game
version from manifest ID parsing)
- This ensures patched profiles show the patch version while unpatched profiles
continue displaying the base game version

💡 Iterate on the plan with: @coderabbitai <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!