-
Notifications
You must be signed in to change notification settings - Fork 13
CL@v0.0.55 #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CL@v0.0.55 #127
Conversation
Deploying alto with
|
Latest commit: |
260149e
|
Status: | ✅ Deploy successful! |
Preview URL: | https://2b4af9dc.alto-8k4.pages.dev |
Branch Preview URL: | https://v0-0-55-integration.alto-8k4.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares the v0.0.55 release by adding new metrics panels, improving archive APIs, standardizing string formatting, and streamlining CI.
- Switch utility and client modules to Rust’s interpolation-style
format!
calls. - Expand
Config
structs with freezer table size settings and refactor archives toprunable
/immutable
patterns in the syncer and engine. - Add dashboard panels for freezer resizes and disk I/O, adjust layout, bump workspace dependencies, and simplify GitHub Actions with sccache and cache improvements.
Reviewed Changes
Copilot reviewed 16 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
inspector/src/utils.rs | Replace positional format! with named interpolation |
client/src/utils.rs | Update health endpoint formatting |
client/src/consensus.rs | Apply interpolation to all path-builder functions |
chain/src/lib.rs | Introduce FREEZER_TABLE_INITIAL_SIZE for test configuration |
chain/src/engine.rs | Add initial size fields for freezer tables in Config |
chain/src/actors/syncer/mod.rs | Document new freezer size fields in syncer Config |
chain/src/actors/syncer/coordinator.rs | Change generic bound from Array to PublicKey |
chain/src/actors/syncer/actor.rs | Migrate from Archive to prunable /immutable archives |
chain/src/actors/application/actor.rs | Restore finalize log, make broadcast log debug, update built tracking |
chain/dashboard.json | Add freezer resizes & disk I/O panels and adjust positions |
chain/README.md | Update CLI example parameters |
Cargo.toml | Bump commonware dependencies to v0.0.55 |
.github/workflows and actions/setup/action.yml | Remove explicit Rust-version inputs, add sccache and caching tweaks |
Comments suppressed due to low confidence (4)
chain/dashboard.json:3353
- The
current.text
field was changed from an array to a string, which may not match the dashboard schema and could break panel rendering. Verify the required type and keep it consistent with other entries.
"text": "All",
chain/src/lib.rs:120
- [nitpick] The comment says
1MB
but the constant is a count of entries. Consider clarifying the unit in the comment, e.g.,// 2^14 entries (~1 MB at 64 bytes each)
to avoid confusion.
const FREEZER_TABLE_INITIAL_SIZE: u32 = 2u32.pow(14); // 1MB
chain/src/actors/application/actor.rs:154
- The code treats
built
(an Arc<Mutex<Option<(View, Block)>>>) like a tuple. You need tolock()
the mutex and unwrap theOption
before destructuring, for example:
let (view, block) = built.lock().unwrap().as_ref().unwrap().clone();
view = built.0,
client/src/consensus.rs:9
- [nitpick] There are many near-identical path-builder functions in this module. Consider extracting a helper like
fn build_path(base: &str, segments: &[&str]) -> String
to reduce duplication and ease future changes.
fn seed_upload_path(base: String) -> String {
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 52.14% 51.85% -0.30%
==========================================
Files 21 21
Lines 3421 3051 -370
==========================================
- Hits 1784 1582 -202
+ Misses 1637 1469 -168
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Fixes: #124
Fixes: #126
Related: https://github.com/commonwarexyz/monorepo/releases/tag/v0.0.55
TODO