Skip to content

CL@v0.0.55 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 11, 2025
Merged

CL@v0.0.55 #127

merged 20 commits into from
Jul 11, 2025

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Jul 11, 2025

Fixes: #124
Fixes: #126
Related: https://github.com/commonwarexyz/monorepo/releases/tag/v0.0.55

TODO

  • Add freezer resizes + disk IOPS to dashboard
  • Restore finalize log, make broadcast log debug

@patrick-ogrady patrick-ogrady marked this pull request as draft July 11, 2025 16:13
Copy link

cloudflare-workers-and-pages bot commented Jul 11, 2025

Deploying alto with  Cloudflare Pages  Cloudflare Pages

Latest commit: 260149e
Status: ✅  Deploy successful!
Preview URL: https://2b4af9dc.alto-8k4.pages.dev
Branch Preview URL: https://v0-0-55-integration.alto-8k4.pages.dev

View logs

@patrick-ogrady patrick-ogrady changed the title v0.0.55 Integration CL@v0.0.55 Jul 11, 2025
@patrick-ogrady patrick-ogrady requested a review from Copilot July 11, 2025 21:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the v0.0.55 release by adding new metrics panels, improving archive APIs, standardizing string formatting, and streamlining CI.

  • Switch utility and client modules to Rust’s interpolation-style format! calls.
  • Expand Config structs with freezer table size settings and refactor archives to prunable/immutable patterns in the syncer and engine.
  • Add dashboard panels for freezer resizes and disk I/O, adjust layout, bump workspace dependencies, and simplify GitHub Actions with sccache and cache improvements.

Reviewed Changes

Copilot reviewed 16 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
inspector/src/utils.rs Replace positional format! with named interpolation
client/src/utils.rs Update health endpoint formatting
client/src/consensus.rs Apply interpolation to all path-builder functions
chain/src/lib.rs Introduce FREEZER_TABLE_INITIAL_SIZE for test configuration
chain/src/engine.rs Add initial size fields for freezer tables in Config
chain/src/actors/syncer/mod.rs Document new freezer size fields in syncer Config
chain/src/actors/syncer/coordinator.rs Change generic bound from Array to PublicKey
chain/src/actors/syncer/actor.rs Migrate from Archive to prunable/immutable archives
chain/src/actors/application/actor.rs Restore finalize log, make broadcast log debug, update built tracking
chain/dashboard.json Add freezer resizes & disk I/O panels and adjust positions
chain/README.md Update CLI example parameters
Cargo.toml Bump commonware dependencies to v0.0.55
.github/workflows and actions/setup/action.yml Remove explicit Rust-version inputs, add sccache and caching tweaks
Comments suppressed due to low confidence (4)

chain/dashboard.json:3353

  • The current.text field was changed from an array to a string, which may not match the dashboard schema and could break panel rendering. Verify the required type and keep it consistent with other entries.
                    "text": "All",

chain/src/lib.rs:120

  • [nitpick] The comment says 1MB but the constant is a count of entries. Consider clarifying the unit in the comment, e.g., // 2^14 entries (~1 MB at 64 bytes each) to avoid confusion.
    const FREEZER_TABLE_INITIAL_SIZE: u32 = 2u32.pow(14); // 1MB

chain/src/actors/application/actor.rs:154

  • The code treats built (an Arc<Mutex<Option<(View, Block)>>>) like a tuple. You need to lock() the mutex and unwrap the Option before destructuring, for example:
let (view, block) = built.lock().unwrap().as_ref().unwrap().clone();
                        view = built.0,

client/src/consensus.rs:9

  • [nitpick] There are many near-identical path-builder functions in this module. Consider extracting a helper like fn build_path(base: &str, segments: &[&str]) -> String to reduce duplication and ease future changes.
fn seed_upload_path(base: String) -> String {

@patrick-ogrady patrick-ogrady marked this pull request as ready for review July 11, 2025 22:56
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.43836% with 49 lines in your changes missing coverage. Please review.

Project coverage is 51.85%. Comparing base (3bcb093) to head (260149e).

Files with missing lines Patch % Lines
chain/src/bin/setup.rs 0.00% 22 Missing ⚠️
chain/src/bin/validator.rs 0.00% 8 Missing ⚠️
client/src/consensus.rs 0.00% 8 Missing ⚠️
chain/src/actors/syncer/actor.rs 93.82% 5 Missing ⚠️
inspector/src/utils.rs 0.00% 4 Missing ⚠️
chain/src/actors/application/actor.rs 80.00% 1 Missing ⚠️
client/src/utils.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   52.14%   51.85%   -0.30%     
==========================================
  Files          21       21              
  Lines        3421     3051     -370     
==========================================
- Hits         1784     1582     -202     
+ Misses       1637     1469     -168     
Files with missing lines Coverage Δ
chain/src/actors/syncer/coordinator.rs 100.00% <ø> (ø)
chain/src/engine.rs 97.91% <100.00%> (-0.24%) ⬇️
chain/src/lib.rs 95.03% <100.00%> (-0.37%) ⬇️
chain/src/actors/application/actor.rs 88.28% <80.00%> (-2.19%) ⬇️
client/src/utils.rs 0.00% <0.00%> (ø)
inspector/src/utils.rs 0.00% <0.00%> (ø)
chain/src/actors/syncer/actor.rs 88.61% <93.82%> (+0.77%) ⬆️
chain/src/bin/validator.rs 0.00% <0.00%> (ø)
client/src/consensus.rs 0.00% <0.00%> (ø)
chain/src/bin/setup.rs 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bcb093...260149e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@patrick-ogrady patrick-ogrady merged commit bf9ab52 into main Jul 11, 2025
9 checks passed
@patrick-ogrady patrick-ogrady deleted the v0.0.55-integration branch July 11, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relaunch with 2 vCPU + 4 GB RAM Migrate Archive to Disk-Based + Immutable Variant
2 participants