COMP: Update CMake files removing support for Qt 4.x #1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove use of Qt4 macros
* Anticipate integration of Qt6 by:
- explicitly reporting an error message if corresponding CMake code is
not implemented.
- switching from using Qt5::Module to Qt${CTK_QT_VERSION}::Module where
associated logic is straightforward.
jcfr
force-pushed
the
remove-qt4-support-from-cmake-files
branch
from
21beda9 to
838f11d
Compare
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of Qt4 macros
Anticipate integration of Qt6 by:
explicitly reporting an error message if corresponding CMake code is not implemented.
switching from using Qt5::Module to Qt${CTK_QT_VERSION}::Module where associated logic is straightforward.