Fixes from the code review on 11/17 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rspeer
reviewed
Nov 30, 2017
conceptnet5/readers/cc_cedict.py
Outdated
|
|
||
| # Remove 'lit.', 'fig.' | ||
| definition = LIT_FIG_REGEX.sub('', definition) | ||
|
|
||
| # Expand sth and sb | ||
| definition = definition.replace('sth', 'something') | ||
| definition = definition.replace('sb', 'someone') | ||
| definition = definition.replace(' sth ', 'something') |
There was a problem hiding this comment.
I think this would fail for two reasons. It doesn't match words at the end of the definition, and it deletes the spaces surrounding the word.
This would convert the definition "to give sth to sb" to "to givesomethingto sb".
rspeer
reviewed
Nov 30, 2017
| @@ -230,3 +206,4 @@ | |||
| /c/tr/test /c/en/test 0.25 /d/wiktionary/en /r/EtymologicallyRelatedTo | |||
| /c/tr/test /c/en/test 1.0 /d/wiktionary/de /r/Synonym | |||
| /c/tr/test /c/en/test 1.0 /d/wiktionary/en /r/RelatedTo | |||
| /c/zh/馬口鐵 /c/zh/马口铁 1.0 /d/cc_cedict /r/Synonym | |||
There was a problem hiding this comment.
Can we have a cedict test involving fixing "sth" in a definition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: