Use a local socket connection to the ConceptNet database #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes ConceptNet default to connecting to PostgreSQL via a "local socket", a file-like object in
/var/run.I think this is more efficient than connecting over a network port, but the primary advantage is that this kind of connection can be handled differently by PostgreSQL, including not requiring a password.
As I try to get rid of Docker, this makes a good substitute for the fact that I managed to configure the PostgreSQL within Docker to never require passwords. (It'll still use a password if you supply one in the appropriate environment variable, so this shouldn't break things for people who set up a password and stuff to run ConceptNet outside of Docker.)