-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update coding guidelines for using View Bindings #6
Conversation
Updating the doc based on the discussion in commons-app/apps-android-commons#3530
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As we could edit the wiki before, feel free to merge future pull requests without review for now - we can adjust that if it becomes a problem in future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the late comment. Just wanted to share my concern regarding a possible contradiction.
``` | ||
### Butterknife | ||
|
||
Contributors have the option of using [butterknife](https://github.com/JakeWharton/butterknife) for their view bindings. We recommend doing so if you can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this sentence kind of contradict the following sentence found above?
We have decided to move away from Butterknife and gradually replace its usage with Kotlin Android Extensions ViewBinding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have the availability to make a PR to delete the recommendation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Just so I understand correctly, do you mean this:
Contributors have the option of using [butterknife](https://github.com/JakeWharton/butterknife) for their view bindings. We recommend doing so if you can. | |
Contributors have the option of using [butterknife](https://github.com/JakeWharton/butterknife) for their view bindings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: I've created #9 with the change.
Updating the doc based on the discussion in commons-app/apps-android-commons#3530