Update coding guidelines for using View Bindings #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the doc based on the discussion in commons-app/apps-android-commons#3530
domdomegg
approved these changes
Mar 17, 2020
macgills
approved these changes
Mar 18, 2020
sivaraam
reviewed
Mar 18, 2020
| ``` | ||
| ### Butterknife | ||
|
|
||
| Contributors have the option of using [butterknife](https://github.com/JakeWharton/butterknife) for their view bindings. We recommend doing so if you can. |
There was a problem hiding this comment.
Doesn't this sentence kind of contradict the following sentence found above?
We have decided to move away from Butterknife and gradually replace its usage with Kotlin Android Extensions ViewBinding.
There was a problem hiding this comment.
Do you have the availability to make a PR to delete the recommendation?
There was a problem hiding this comment.
Sure. Just so I understand correctly, do you mean this:
Suggested change
| Contributors have the option of using [butterknife](https://github.com/JakeWharton/butterknife) for their view bindings. We recommend doing so if you can. | |
| Contributors have the option of using [butterknife](https://github.com/JakeWharton/butterknife) for their view bindings. |
There was a problem hiding this comment.
FYI: I've created #9 with the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the doc based on the discussion in commons-app/apps-android-commons#3530